Skip to content

Comments

fix: TAP-9678 StarRocks cache data is incomplete#179

Merged
jarad0628 merged 3 commits intomainfrom
TAP-9678
Feb 24, 2026
Merged

fix: TAP-9678 StarRocks cache data is incomplete#179
jarad0628 merged 3 commits intomainfrom
TAP-9678

Conversation

@mnianqi
Copy link
Contributor

@mnianqi mnianqi commented Feb 5, 2026

No description provided.

@ply0011 ply0011 marked this pull request as draft February 5, 2026 09:47
@ply0011 ply0011 marked this pull request as ready for review February 5, 2026 09:47
@augmentcode
Copy link

augmentcode bot commented Feb 5, 2026

🤖 Augment PR Summary

Summary: Adds flush-offset callback plumbing so targets (e.g., StarRocks) can receive complete offset metadata after a successful flush.

Changes:

  • Introduced TapCallbackOffset to package batch/stream offsets plus table, stage, timestamps, and nodeIds.
  • Extended TapConnectionContext with a flushOffsetCallback (Consumer<Object>) hook to deliver the offset payload.
  • Added ConnectionOptions.FLUSH_OFFSET_CALLBACK option key for wiring/configuring the callback.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@jarad0628 jarad0628 merged commit bb7d146 into main Feb 24, 2026
@jarad0628 jarad0628 deleted the TAP-9678 branch February 24, 2026 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants